klbr/khoj
1
0
Fork 0
mirror of https://github.com/khoaliber/khoj.git synced 2026-03-02 13:18:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Set type hints and reorder args of all converse_[provider] methods

Browse Source 
- Query is more important and should be passed before references
- Add type hints to user query and references for code readability
This commit is contained in:
Debanjum
2025-05-21 16:25:32 -07:00
parent 2ea16298aa
commit 97c5222b04
6 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/khoj/processor/conversation/anthropic/anthropic_chat.py
View File

@@ -140,8 +140,8 @@ def anthropic_send_message_to_model(
async def converse_anthropic(
references,
user_query,
user_query: str,
references: list[dict],
online_results: Optional[Dict[str, Dict]] = None,
code_results: Optional[Dict[str, Dict]] = None,
operator_results: Optional[Dict[str, str]] = None,

4
src/khoj/processor/conversation/google/gemini_chat.py
View File

@@ -162,8 +162,8 @@ def gemini_send_message_to_model(
async def converse_gemini(
references,
user_query,
user_query: str,
references: list[dict],
online_results: Optional[Dict[str, Dict]] = None,
code_results: Optional[Dict[str, Dict]] = None,
operator_results: Optional[Dict[str, str]] = None,

4
src/khoj/processor/conversation/offline/chat_model.py
View File

@@ -148,8 +148,8 @@ def filter_questions(questions: List[str]):
async def converse_offline(
user_query,
references=[],
user_query: str,
references: list[dict] = [],
online_results={},
code_results={},
conversation_log={},

4
src/khoj/processor/conversation/openai/gpt.py
View File

@@ -165,8 +165,8 @@ def send_message_to_model(
async def converse_openai(
references,
user_query,
user_query: str,
references: list[dict],
online_results: Optional[Dict[str, Dict]] = None,
code_results: Optional[Dict[str, Dict]] = None,
operator_results: Optional[Dict[str, str]] = None,

2
src/khoj/processor/conversation/utils.py
View File

@@ -387,7 +387,7 @@ def gather_raw_query_files(
def generate_chatml_messages_with_context(
user_message,
user_message: str,
system_message: str = None,
conversation_log={},
model_name="gpt-4o-mini",

6
src/khoj/routers/helpers.py
View File

@@ -1449,8 +1449,8 @@ async def agenerate_chat_response(
api_key = openai_chat_config.api_key
chat_model_name = chat_model.name
chat_response_generator = converse_openai(
compiled_references,
query_to_run,
compiled_references,
query_images=query_images,
online_results=online_results,
code_results=code_results,
@@ -1479,8 +1479,8 @@ async def agenerate_chat_response(
api_key = chat_model.ai_model_api.api_key
api_base_url = chat_model.ai_model_api.api_base_url
chat_response_generator = converse_anthropic(
compiled_references,
query_to_run,
compiled_references,
query_images=query_images,
online_results=online_results,
code_results=code_results,
@@ -1508,8 +1508,8 @@ async def agenerate_chat_response(
api_key = chat_model.ai_model_api.api_key
api_base_url = chat_model.ai_model_api.api_base_url
chat_response_generator = converse_gemini(
compiled_references,
query_to_run,
compiled_references,
online_results=online_results,
code_results=code_results,
operator_results=operator_results,