klbr/khoj
1
0
Fork 0
mirror of https://github.com/khoaliber/khoj.git synced 2026-03-07 13:23:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix offline chat actor tests

Browse Source 
Do not check for original q in extracted questions. Since this was
removed in a previous commit
This commit is contained in:
Debanjum Singh Solanky
2024-04-24 00:35:13 +05:30
parent 4f7237b158
commit f2db8d7d99
1 changed files with 9 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
tests/test_offline_chat_actors.py
View File

@@ -92,29 +92,16 @@ def test_extract_question_with_date_filter_from_relative_year():
) )
# ----------------------------------------------------------------------------------------------------
@pytest.mark.chatquality
@freeze_time("1984-04-02", ignore=["transformers"])
def test_extract_question_includes_root_question(loaded_model):
# Act
response = extract_questions_offline("Which countries have I visited this year?", loaded_model=loaded_model)
# Assert
assert len(response) >= 1
assert response[-1] == "Which countries have I visited this year?"
# ---------------------------------------------------------------------------------------------------- # ----------------------------------------------------------------------------------------------------
@pytest.mark.chatquality @pytest.mark.chatquality
def test_extract_multiple_explicit_questions_from_message(loaded_model): def test_extract_multiple_explicit_questions_from_message(loaded_model):
# Act # Act
response = extract_questions_offline("What is the Sun? What is the Moon?", loaded_model=loaded_model) responses = extract_questions_offline("What is the Sun? What is the Moon?", loaded_model=loaded_model)
# Assert # Assert
expected_responses = ["What is the Sun?", "What is the Moon?"] assert len(responses) >= 2
assert len(response) >= 2 assert ["the Sun" in response for response in responses]
assert expected_responses[0] == response[-2] assert ["the Moon" in response for response in responses]
assert expected_responses[1] == response[-1]
# ---------------------------------------------------------------------------------------------------- # ----------------------------------------------------------------------------------------------------
@@ -159,13 +146,13 @@ def test_generate_search_query_using_question_from_chat_history(loaded_model):
"son", "son",
"sons", "sons",
"children", "children",
"family",
] ]
# Assert # Assert
assert len(response) >= 1 assert len(response) >= 1
assert response[-1] == query, "Expected last question to be the user query, but got: " + response[-1]
# Ensure the remaining generated search queries use proper nouns and chat history context # Ensure the remaining generated search queries use proper nouns and chat history context
for question in response[:-1]: for question in response:
if "Barbara" in question: if "Barbara" in question:
assert any([expected_relation in question for expected_relation in any_expected_with_barbara]), ( assert any([expected_relation in question for expected_relation in any_expected_with_barbara]), (
"Expected search queries using proper nouns and chat history for context, but got: " + question "Expected search queries using proper nouns and chat history for context, but got: " + question
@@ -198,14 +185,13 @@ def test_generate_search_query_using_answer_from_chat_history(loaded_model):
expected_responses = [ expected_responses = [
"Barbara", "Barbara",
"Robert", "Anderson",
"daughter",
] ]
# Assert # Assert
assert len(response) >= 1 assert len(response) >= 1
assert any([expected_response in response[0] for expected_response in expected_responses]), ( assert any([expected_response in response[0] for expected_response in expected_responses]), (
"Expected chat actor to mention Darth Vader's daughter, but got: " + response[0] "Expected chat actor to mention person's by name, but got: " + response[0]
) )
@@ -461,7 +447,7 @@ My sister, Aiyla is married to Tolga. They have 3 kids, Yildiz, Ali and Ahmet.""
response = "".join([response_chunk for response_chunk in response_gen]) response = "".join([response_chunk for response_chunk in response_gen])
# Assert # Assert
expected_responses = ["which sister", "Which sister", "which of your sister", "Which of your sister"] expected_responses = ["which sister", "Which sister", "which of your sister", "Which of your sister", "Which one"]
assert any([expected_response in response for expected_response in expected_responses]), ( assert any([expected_response in response for expected_response in expected_responses]), (
"Expected chat actor to ask for clarification in response, but got: " + response "Expected chat actor to ask for clarification in response, but got: " + response
) )