From b6cdc5c7cb6a1cbfd611c9c439fcdcaad36ea7af Mon Sep 17 00:00:00 2001
From: Debanjum Singh Solanky <debanjum@gmail.com>
Date: Sun, 5 Mar 2023 17:34:09 -0600
Subject: [PATCH] Do not expose answer API as a chat type in chat web interface
 or API

Answer does not rely on past conversations, just the knowledge base.
It is meant for one off interactions, like search rather than a
continuing conversation like chat

For now it is only exposed via API. Later it will be expose in the
interfaces as well

Remove ability to select different chat types from the chat web
interface as there is only a single chat type

Stop appending answers to the conversation logs
---
 src/khoj/interface/web/chat.html | 26 ++++----------------------
 src/khoj/routers/api_beta.py     | 10 ----------
 tests/test_chatbot.py            |  2 +-
 3 files changed, 5 insertions(+), 33 deletions(-)

diff --git a/src/khoj/interface/web/chat.html b/src/khoj/interface/web/chat.html
index cba6eb2d..f72824b8 100644
--- a/src/khoj/interface/web/chat.html
+++ b/src/khoj/interface/web/chat.html
@@ -9,12 +9,6 @@
         <link rel="manifest" href="/static/khoj.webmanifest">
     </head>
     <script>
-        function setTypeFieldInUrl(type) {
-            let url = new URL(window.location.href);
-            url.searchParams.set("t", type.value);
-            window.history.pushState({}, "", url.href);
-        }
-
         function formatDate(date) {
             // Format date in HH:MM, DD MMM YYYY format
             let time_string = date.toLocaleTimeString('en-IN', { hour: '2-digit', minute: '2-digit', hour12: false });
@@ -31,15 +25,14 @@
                     <div class="chat-message-text ${by}">${message}</div>
                 </div>
             `;
-            // Scroll to bottom of input-body element
+            // Scroll to bottom of chat-body element
             document.getElementById("chat-body").scrollTop = document.getElementById("chat-body").scrollHeight;
         }
 
         function chat() {
             // Extract required fields for search from form
             query = document.getElementById("chat-input").value.trim();
-            type_ = document.getElementById("chat-type").value;
-            console.log(`Query: ${query}, Type: ${type_}`);
+            console.log(`Query: ${query}`);
 
             // Short circuit on empty query
             if (query.length === 0)
@@ -50,7 +43,7 @@
             document.getElementById("chat-input").value = "";
 
             // Generate backend API URL to execute query
-            url = `/api/beta/${type_}?q=${encodeURIComponent(query)}`;
+            url = `/api/beta/chat?q=${encodeURIComponent(query)}`;
 
             // Call specified Khoj API
             fetch(url)
@@ -71,11 +64,6 @@
         }
 
         window.onload = function () {
-            // Fill type field with value passed in URL query parameters, if any.
-            var type_via_url = new URLSearchParams(window.location.search).get("t");
-            if (type_via_url)
-                document.getElementById("chat-type").value = type_via_url;
-
             fetch('/api/beta/chat')
                 .then(response => response.json())
                 .then(data => data.response)
@@ -107,12 +95,6 @@
         <!-- Chat Footer -->
         <div id="chat-footer">
             <input type="text" id="chat-input" class="option" onkeyup=incrementalChat(event) autofocus="autofocus" placeholder="What is the meaning of life?">
-
-            <!--Select Chat Type from: Chat, Summarize -->
-            <select id="chat-type" class="option" onchange="setTypeFieldInUrl(this)">
-                <option value="answer">Answer</option>
-                <option value="chat">Chat</option>
-            </select>
         </div>
     </body>
 
@@ -215,7 +197,7 @@
         #chat-footer {
             padding: 0;
             display: grid;
-            grid-template-columns: minmax(70px, 85%) auto;
+            grid-template-columns: minmax(70px, 100%);
             grid-column-gap: 10px;
             grid-row-gap: 10px;
         }
diff --git a/src/khoj/routers/api_beta.py b/src/khoj/routers/api_beta.py
index 6a7777c0..7d08d0da 100644
--- a/src/khoj/routers/api_beta.py
+++ b/src/khoj/routers/api_beta.py
@@ -54,10 +54,6 @@ def answer_beta(q: str):
     model = state.processor_config.conversation.model
     api_key = state.processor_config.conversation.openai_api_key
 
-    # Load Conversation History
-    chat_session = state.processor_config.conversation.chat_session
-    meta_log = state.processor_config.conversation.meta_log
-
     # Collate context for GPT
     result_list = search(q, n=2, r=True)
     collated_result = "\n\n".join([f"# {item.additional['compiled']}" for item in result_list])
@@ -71,12 +67,6 @@ def answer_beta(q: str):
         gpt_response = str(e)
         status = "error"
 
-    # Update Conversation History
-    state.processor_config.conversation.chat_session = message_to_prompt(q, chat_session, gpt_message=gpt_response)
-    state.processor_config.conversation.meta_log["chat"] = message_to_log(
-        q, gpt_response, conversation_log=meta_log.get("chat", [])
-    )
-
     return {"status": status, "response": gpt_response}
 
 
diff --git a/tests/test_chatbot.py b/tests/test_chatbot.py
index fdd99548..69315394 100644
--- a/tests/test_chatbot.py
+++ b/tests/test_chatbot.py
@@ -2,7 +2,7 @@
 import pytest
 
 # Internal Packages
-from khoj.processor.conversation.gpt import converse, understand, message_to_prompt
+from khoj.processor.conversation.gpt import converse, message_to_prompt
 
 
 # Initialize variables for tests