klbr/khoj
1
0
Fork 0
mirror of https://github.com/khoaliber/khoj.git synced 2026-03-09 13:25:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix markdownRenderer arg to allow chat responses in Obsidian plugin (#619)

Browse Source 
- Issue
Users with Dataview plugin would have error as its markdown
post-processor expects the sourcePath to be a string

This prevents Khoj from responding to chat messages in the Obsidian
chat modal. Search via Obsidian still works but it throws the same
dataview plugin error

- Fix
Pass a string as sourcePath to markdownRenderer to fix failing chat response
and stop throwing dataview errors on search

Resolves #614, Resolves #606
This commit is contained in:
Debanjum
2024-01-18 10:18:31 +05:30
committed by GitHub
parent c8dbe8ee7b 1a46734485
commit 8b4dd16255
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/interface/obsidian/src/chat_modal.ts
View File

@@ -182,7 +182,7 @@ export class KhojChatModal extends Modal {
chat_message_body_text_el.innerHTML = message; chat_message_body_text_el.innerHTML = message;
} else { } else {
// @ts-ignore // @ts-ignore
MarkdownRenderer.renderMarkdown(message, chat_message_body_text_el, null, null); MarkdownRenderer.renderMarkdown(message, chat_message_body_text_el, '', null);
} }
// Remove user-select: none property to make text selectable // Remove user-select: none property to make text selectable
@@ -221,7 +221,7 @@ export class KhojChatModal extends Modal {
this.result += additionalMessage; this.result += additionalMessage;
htmlElement.innerHTML = ""; htmlElement.innerHTML = "";
// @ts-ignore // @ts-ignore
await MarkdownRenderer.renderMarkdown(this.result, htmlElement, null, null); await MarkdownRenderer.renderMarkdown(this.result, htmlElement, '', null);
// Scroll to bottom of modal, till the send message input box // Scroll to bottom of modal, till the send message input box
this.modalEl.scrollTop = this.modalEl.scrollHeight; this.modalEl.scrollTop = this.modalEl.scrollHeight;
} }

2
src/interface/obsidian/src/search_modal.ts
View File

@@ -124,7 +124,7 @@ export class KhojSearchModal extends SuggestModal<SearchResult> {
let result_el = el.createEl("div", { cls: 'khoj-result-entry' }) let result_el = el.createEl("div", { cls: 'khoj-result-entry' })
// @ts-ignore // @ts-ignore
MarkdownRenderer.renderMarkdown(snipped_entry + entry_snipped_indicator, result_el, null, null); MarkdownRenderer.renderMarkdown(snipped_entry + entry_snipped_indicator, result_el, result.file, null);
} }
async onChooseSuggestion(result: SearchResult, _: MouseEvent | KeyboardEvent) { async onChooseSuggestion(result: SearchResult, _: MouseEvent | KeyboardEvent) {