klbr/khoj
1
0
Fork 0
mirror of https://github.com/khoaliber/khoj.git synced 2026-03-09 21:29:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix creating GUI panels for unconfigured search, processor types

Browse Source 
Repro:
1. Open khoj server with `khoj` on first run
2. Install/enable Khoj Obsidian plugin (to configure khoj server)
3. Restart khoj server with `khoj`

Bug:
- Unconfigured processor and search_types are instantiated as None in
  self.current_config
- While creating the desktop GUI, these null configs are attempted to
  be accessed as valid dictionaries for creating their GUI panels
- This results in the null ref errors

Fix:
Use default config to create their GUI elements for unconfigured
search and processor types

Resolves #167
This commit is contained in:
Debanjum Singh Solanky
2023-02-28 23:25:19 -06:00
parent e77a5ffc83
commit 8914dbd073
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/khoj/interface/desktop/main_window.py
View File

@@ -58,13 +58,18 @@ class MainWindow(QtWidgets.QMainWindow):
# Add Settings Panels for each Search Type to Configure Window Layout # Add Settings Panels for each Search Type to Configure Window Layout
self.search_settings_panels = [] self.search_settings_panels = []
for search_type in SearchType: for search_type in SearchType:
current_content_config = self.current_config["content-type"].get(search_type, {}) current_content_config = self.current_config["content-type"][search_type] or self.get_default_config(
search_type=search_type
)
self.search_settings_panels += [self.add_settings_panel(current_content_config, search_type)] self.search_settings_panels += [self.add_settings_panel(current_content_config, search_type)]
# Add Conversation Processor Panel to Configure Screen # Add Conversation Processor Panel to Configure Screen
self.processor_settings_panels = [] self.processor_settings_panels = []
conversation_type = ProcessorType.Conversation conversation_type = ProcessorType.Conversation
current_conversation_config = self.current_config["processor"].get(conversation_type, {}) if self.current_config["processor"] and conversation_type in self.current_config["processor"]:
current_conversation_config = self.current_config["processor"][conversation_type]
else:
current_conversation_config = self.get_default_config(processor_type=conversation_type)
self.processor_settings_panels += [self.add_processor_panel(current_conversation_config, conversation_type)] self.processor_settings_panels += [self.add_processor_panel(current_conversation_config, conversation_type)]
# Add Action Buttons Panel # Add Action Buttons Panel