From 865d12b6f22ba7ffa909a40a549883c43ff85a52 Mon Sep 17 00:00:00 2001
From: Debanjum Singh Solanky <debanjum@gmail.com>
Date: Thu, 27 Apr 2023 19:10:55 +0800
Subject: [PATCH] Fix escaping quote in chat references to prevent it breaking
 out of html

---
 src/interface/obsidian/src/chat_modal.ts | 4 ++--
 src/khoj/interface/web/chat.html         | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/interface/obsidian/src/chat_modal.ts b/src/interface/obsidian/src/chat_modal.ts
index ffbdb80d..59f84789 100644
--- a/src/interface/obsidian/src/chat_modal.ts
+++ b/src/interface/obsidian/src/chat_modal.ts
@@ -62,7 +62,7 @@ export class KhojChatModal extends Modal {
     generateReference(messageEl: any, reference: string, index: number) {
         // Generate HTML for Chat Reference
         // `<sup><abbr title="${escaped_ref}" tabindex="0">${index}</abbr></sup>`;
-        let escaped_ref = reference.replace(/"/g, "\\\"")
+        let escaped_ref = reference.replace(/"/g, "&quot;")
         return messageEl.createEl("sup").createEl("abbr", {
             attr: {
                 title: escaped_ref,
@@ -75,7 +75,7 @@ export class KhojChatModal extends Modal {
     renderMessageWithReferences(message: string, sender: string, context?: [string], dt?: Date) {
         let messageEl = this.renderMessage(message, sender, dt);
         if (context && !!messageEl) {
-            context.map((reference, index) => this.generateReference(messageEl, reference, index+1));
+            context.map((reference, index) => this.generateReference(messageEl, reference, index + 1));
         }
     }
 
diff --git a/src/khoj/interface/web/chat.html b/src/khoj/interface/web/chat.html
index ae038fde..5dfebca7 100644
--- a/src/khoj/interface/web/chat.html
+++ b/src/khoj/interface/web/chat.html
@@ -17,8 +17,10 @@
         }
 
         function generateReference(reference, index) {
+            // Escape reference for HTML rendering
+            let escaped_ref = reference.replaceAll('"', '&quot;');
+
             // Generate HTML for Chat Reference
-            let escaped_ref = reference.replaceAll("\"", "\\\"")
             return `<sup><abbr title="${escaped_ref}" tabindex="0">${index}</abbr></sup>`;
         }