klbr/khoj
1
0
Fork 0
mirror of https://github.com/khoaliber/khoj.git synced 2026-03-09 13:25:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix to create chat with custom agents from obsidian (#1216)

Browse Source 
The function createNewConversation is never called with the agentSlug
specified so its always opening a new Conversation with the default Agent
This commit is contained in:
Debanjum
2025-08-20 19:07:16 -07:00
committed by GitHub
parent fa143d45b9 4728098cad
commit 573c6a32e1
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/interface/obsidian/src/chat_view.ts
View File

@@ -127,7 +127,7 @@ export class KhojChatView extends KhojPaneView {
// Register chat view keybindings // Register chat view keybindings
this.scope = new Scope(this.app.scope); this.scope = new Scope(this.app.scope);
this.scope.register(["Ctrl", "Alt"], 'n', (_) => this.createNewConversation()); this.scope.register(["Ctrl", "Alt"], 'n', (_) => this.createNewConversation(this.currentAgent));
this.scope.register(["Ctrl", "Alt"], 'o', async (_) => await this.toggleChatSessions()); this.scope.register(["Ctrl", "Alt"], 'o', async (_) => await this.toggleChatSessions());
this.scope.register(["Ctrl", "Alt"], 'v', (_) => this.speechToText(new KeyboardEvent('keydown'))); this.scope.register(["Ctrl", "Alt"], 'v', (_) => this.speechToText(new KeyboardEvent('keydown')));
this.scope.register(["Ctrl"], 'f', (_) => new KhojSearchModal(this.app, this.setting).open()); this.scope.register(["Ctrl"], 'f', (_) => new KhojSearchModal(this.app, this.setting).open());
@@ -220,7 +220,7 @@ export class KhojChatView extends KhojPaneView {
await this.fetchAgents(); await this.fetchAgents();
// Populate the agent selector in the header // Populate the agent selector in the header
const headerAgentSelect = this.contentEl.querySelector('#khoj-header-agent-select') as HTMLSelectElement; const headerAgentSelect = this.contentEl.querySelector('.khoj-header-agent-select') as HTMLSelectElement;
if (headerAgentSelect && this.agents.length > 0) { if (headerAgentSelect && this.agents.length > 0) {
// Clear existing options // Clear existing options
headerAgentSelect.innerHTML = ''; headerAgentSelect.innerHTML = '';
@@ -943,7 +943,7 @@ export class KhojChatView extends KhojPaneView {
return learningMoments[Math.floor(Math.random() * learningMoments.length)]; return learningMoments[Math.floor(Math.random() * learningMoments.length)];
} }
async createNewConversation(agentSlug?: string) { async createNewConversation(agentSlug?: string | null) {
let chatBodyEl = this.contentEl.getElementsByClassName("khoj-chat-body")[0] as HTMLElement; let chatBodyEl = this.contentEl.getElementsByClassName("khoj-chat-body")[0] as HTMLElement;
chatBodyEl.innerHTML = ""; chatBodyEl.innerHTML = "";
chatBodyEl.dataset.conversationId = ""; chatBodyEl.dataset.conversationId = "";
@@ -960,6 +960,7 @@ export class KhojChatView extends KhojPaneView {
try { try {
// Create a new conversation with or without an agent // Create a new conversation with or without an agent
let endpoint = `${this.setting.khojUrl}/api/chat/sessions`; let endpoint = `${this.setting.khojUrl}/api/chat/sessions`;
agentSlug = agentSlug || this.currentAgent;
if (agentSlug) { if (agentSlug) {
endpoint += `?agent_slug=${encodeURIComponent(agentSlug)}`; endpoint += `?agent_slug=${encodeURIComponent(agentSlug)}`;
} }
@@ -979,7 +980,7 @@ export class KhojChatView extends KhojPaneView {
this.currentAgent = agentSlug || null; this.currentAgent = agentSlug || null;
// Update agent selector to reflect current agent // Update agent selector to reflect current agent
const agentSelect = this.contentEl.querySelector('.khoj-agent-select') as HTMLSelectElement; const agentSelect = this.contentEl.querySelector('.khoj-header-agent-select') as HTMLSelectElement;
if (agentSelect) { if (agentSelect) {
agentSelect.value = this.currentAgent || ''; agentSelect.value = this.currentAgent || '';
} }
@@ -1009,7 +1010,7 @@ export class KhojChatView extends KhojPaneView {
const newConversationButtonEl = newConversationEl.createEl("button"); const newConversationButtonEl = newConversationEl.createEl("button");
newConversationButtonEl.classList.add("new-conversation-button"); newConversationButtonEl.classList.add("new-conversation-button");
newConversationButtonEl.classList.add("side-panel-button"); newConversationButtonEl.classList.add("side-panel-button");
newConversationButtonEl.addEventListener('click', (_) => this.createNewConversation()); newConversationButtonEl.addEventListener('click', (_) => this.createNewConversation(this.currentAgent));
setIcon(newConversationButtonEl, "plus"); setIcon(newConversationButtonEl, "plus");
newConversationButtonEl.innerHTML += "New"; newConversationButtonEl.innerHTML += "New";
newConversationButtonEl.title = "New Conversation (Ctrl+Alt+N)"; newConversationButtonEl.title = "New Conversation (Ctrl+Alt+N)";
@@ -1223,7 +1224,7 @@ export class KhojChatView extends KhojPaneView {
console.log("Found agent in conversation history:", responseJson.response.agent); console.log("Found agent in conversation history:", responseJson.response.agent);
this.currentAgent = responseJson.response.agent.slug; this.currentAgent = responseJson.response.agent.slug;
// Update the agent selector if it exists // Update the agent selector if it exists
const agentSelect = this.contentEl.querySelector('.khoj-agent-select') as HTMLSelectElement; const agentSelect = this.contentEl.querySelector('.khoj-header-agent-select') as HTMLSelectElement;
if (agentSelect && this.currentAgent) { if (agentSelect && this.currentAgent) {
agentSelect.value = this.currentAgent; agentSelect.value = this.currentAgent;
console.log("Updated agent selector to:", this.currentAgent); console.log("Updated agent selector to:", this.currentAgent);