From 50c797962c432649110abc4df9a2cba575af266e Mon Sep 17 00:00:00 2001
From: Debanjum Singh Solanky <debanjum@gmail.com>
Date: Wed, 11 Jan 2023 19:44:11 -0300
Subject: [PATCH] Jump to Search Result from Khoj Modal even on Obsidian
 Android

Uses longest file path match to find markdown file in vault
corresponding to file of search result returned by Khoj

Allow jumping to search result from khoj plugin modal on Android too
---
 src/interface/obsidian/src/modal.ts | 34 ++++++++++++++---------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/src/interface/obsidian/src/modal.ts b/src/interface/obsidian/src/modal.ts
index 11354e32..bf281fe6 100644
--- a/src/interface/obsidian/src/modal.ts
+++ b/src/interface/obsidian/src/modal.ts
@@ -1,6 +1,5 @@
 import { App, SuggestModal, Notice, request, MarkdownRenderer, Instruction, Platform } from 'obsidian';
 import { KhojSetting } from 'src/settings';
-import { getVaultAbsolutePath } from 'src/utils';
 
 export interface SearchResult {
     entry: string;
@@ -36,7 +35,7 @@ export class KhojModal extends SuggestModal<SearchResult> {
                 purpose: 'to open',
             },
             {
-                command: Platform.isMacOS ? 'cmd ↵': 'ctrl ↵',
+                command: Platform.isMacOS ? 'cmd ↵' : 'ctrl ↵',
                 purpose: 'to rerank',
             },
             {
@@ -73,23 +72,24 @@ export class KhojModal extends SuggestModal<SearchResult> {
     }
 
     async onChooseSuggestion(result: SearchResult, _: MouseEvent | KeyboardEvent) {
+        // Get all markdown files in vault
         const mdFiles = this.app.vault.getMarkdownFiles();
-        const vaultPath = getVaultAbsolutePath();
-
-        if (!vaultPath) {
-            new Notice('Khoj: Cannot open file. Make sure we are in a file system vault');
-            return;
-        }
 
         // Find the vault file matching file of result. Open file at result heading
-        mdFiles.forEach((file) => {
-            if (`${vaultPath}/${file.path}` === result.file) {
-                let resultHeading = result.entry.split('\n', 1)[0];
-                let linkToEntry = `${file.path}${resultHeading}`
-                this.app.workspace.openLinkText(linkToEntry, '');
-                console.log(`Link: ${linkToEntry}, File: ${file.path}, Heading: ${resultHeading}`);
-                return
-            }
-        });
+        mdFiles
+            // Sort by descending length of path
+            // This finds longest path match when multiple files have same name
+            .sort((a, b) => b.path.length - a.path.length)
+            .forEach((file) => {
+                // Find best file match across operating systems
+                // E.g Khoj Server on Linux, Obsidian Vault on Android
+                if (result.file.endsWith(file.path)) {
+                    let resultHeading = result.entry.split('\n', 1)[0];
+                    let linkToEntry = `${file.path}${resultHeading}`
+                    this.app.workspace.openLinkText(linkToEntry, '');
+                    console.log(`Link: ${linkToEntry}, File: ${file.path}, Heading: ${resultHeading}`);
+                    return
+                }
+            });
     }
 }